Yair Zaslavsky has posted comments on this change. Change subject: core: Add local configuration helper ......................................................................
Patch Set 9: Juan, Sorry for the "late thought" about this (Was just explaining some new guy at Infra something about configuration, so I have a question about your patch) - When I worked on configuration infra at the past (I admit I did not use commons-configuration myself) , I provided to all the getXXX (i.e - getInteger) a version which provides a default value (in case the key is not present in configuration store - db, conf file, etc..) - a similar approach is used at our Config class. What do you think about this? -- To view, visit http://gerrit.ovirt.org/6673 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0106a71c3a1c7c145d4ca836225ce2a26aa115f Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Anonymous Coward #1000055 Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
