Tal Nisan has posted comments on this change. Change subject: core: Adding a pool with vm storage allocation ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/36553/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmPoolWithVmsCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmPoolWithVmsCommand.java: Line 140: disksList.addAll(diskInfoDestinationMap.values()); Line 141: } Line 142: // At this point the disks are the template's, which could have another volume type/format Line 143: // This change is for storage allocation validations, "real" override for these values is done in CreateSnapshotCommand. Line 144: for (DiskImage diskImage : disksList) { This will still alter the original diskInfoDestinationMap since we are using the same disk instances and not a clone, moreover, it will redundantly do the loop on the same disks multiplied by the number of the VMs to be created from the pool, we have to deep clone the list once, change the allocation and then add it to the disksList multiple times as necessary according to the number of pools Line 145: diskImage.setVolumeType(VolumeType.Sparse); Line 146: if (getDiskStorageDomain(diskImage).getStorageType().isBlockDomain()) { Line 147: diskImage.setvolumeFormat(VolumeFormat.COW); Line 148: } else { -- To view, visit http://gerrit.ovirt.org/36553 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia46bef12bbc0462bb42956f95bdff1855631e7b6 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
