Tal Nisan has posted comments on this change. Change subject: core: Adding a pool with vm storage allocation ......................................................................
Patch Set 7: (2 comments) http://gerrit.ovirt.org/#/c/36553/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmPoolWithVmsCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmPoolWithVmsCommand.java: Line 159: } Line 160: return domain; Line 161: } Line 162: Line 163: private List<DiskImage> getDiskList() { You have one redundant space after the private modifier Line 164: List<DiskImage> disksList = new ArrayList<>(); Line 165: for (DiskImage diskImage : diskInfoDestinationMap.values()) { Line 166: DiskImage clone = DiskImage.copyOf(diskImage); Line 167: // At this point the disks are the template's, which could have another volume type/format Line 169: clone.setVolumeType(VolumeType.Sparse); Line 170: if (getDiskStorageDomain(diskImage).getStorageType().isBlockDomain()) { Line 171: clone.setvolumeFormat(VolumeFormat.COW); Line 172: } else { Line 173: clone.setvolumeFormat(VolumeFormat.RAW); This should be removed, all image are snapshots based on the template thus they are always COW regardless of the storage domain Line 174: } Line 175: } Line 176: return disksList; Line 177: } -- To view, visit http://gerrit.ovirt.org/36553 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia46bef12bbc0462bb42956f95bdff1855631e7b6 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
