Tal Nisan has posted comments on this change. Change subject: core: Adding a pool with vm storage allocation ......................................................................
Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/36553/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmPoolWithVmsCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmPoolWithVmsCommand.java: Line 141: } Line 142: // At this point the disks are the template's, which could have another volume type/format Line 143: // This change is for storage allocation validations, "real" override for these values is done in CreateSnapshotCommand. Line 144: for (DiskImage diskImage : disksList) { Line 145: diskImage.setVolumeType(VolumeType.Sparse); Too much indentation I think? Line 146: if (getDiskStorageDomain(diskImage).getStorageType().isBlockDomain()) { Line 147: diskImage.setvolumeFormat(VolumeFormat.COW); Line 148: } else { Line 149: diskImage.setvolumeFormat(VolumeFormat.RAW); http://gerrit.ovirt.org/#/c/36553/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java: Line 32: import org.ovirt.engine.core.common.businessentities.VmStatic; Line 33: import org.ovirt.engine.core.common.businessentities.VmTemplate; Line 34: import org.ovirt.engine.core.common.businessentities.VmType; Line 35: import org.ovirt.engine.core.common.businessentities.VolumeFormat; Line 36: import org.ovirt.engine.core.common.businessentities.VolumeType; Redundant (and will break the build on checkstyle) Line 37: import org.ovirt.engine.core.common.config.Config; Line 38: import org.ovirt.engine.core.common.config.ConfigValues; Line 39: import org.ovirt.engine.core.common.errors.VdcBllMessages; Line 40: import org.ovirt.engine.core.common.job.Step; -- To view, visit http://gerrit.ovirt.org/36553 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia46bef12bbc0462bb42956f95bdff1855631e7b6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
