Allon Mureinik has posted comments on this change. Change subject: core: Adding a pool with vm storage allocation ......................................................................
Patch Set 9: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/36553/9/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmPoolWithVmsCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmPoolWithVmsCommand.java: Line 150: protected MultipleStorageDomainsValidator getStorageDomainsValidator(Guid spId, Set<Guid> sdIds) { Line 151: return new MultipleStorageDomainsValidator(spId, sdIds); Line 152: } Line 153: Line 154: private StorageDomain getDiskStorageDomain(DiskImage diskImage) { This isn't used anymore (iiuc, was used in a previous version of this patch) - please remove. Line 155: Guid domainId = diskImage.getStorageIds().get(0); Line 156: StorageDomain domain = destStorages.get(domainId); Line 157: if (domain == null) { Line 158: domain = getStorageDomainDAO().getForStoragePool(domainId, getVmTemplate().getStoragePoolId()); Line 166: DiskImage clone = DiskImage.copyOf(diskImage); Line 167: // At this point the disks are the template's, which could have another volume type/format Line 168: // This change is for storage allocation validations, "real" override for these values is done in CreateSnapshotCommand. Line 169: clone.setVolumeType(VolumeType.Sparse); Line 170: if (getDiskStorageDomain(diskImage).getStorageType().isBlockDomain()) { If this is a sparse disk based on a template, it's always QCOW. Line 171: clone.setvolumeFormat(VolumeFormat.COW); Line 172: } Line 173: } Line 174: return disksList; -- To view, visit http://gerrit.ovirt.org/36553 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia46bef12bbc0462bb42956f95bdff1855631e7b6 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
