Tal Nisan has posted comments on this change.

Change subject: core: Adding a pool with vm storage allocation
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/36553/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java:

Line 345:                 Guid storageId = getParameters().getStorageDomainId();
Line 346:                 ArrayList<Guid> storageIds = new ArrayList<Guid>();
Line 347:                 storageIds.add(storageId);
Line 348:                 for (DiskImage image : 
getVmTemplate().getDiskTemplateMap().values()) {
Line 349:                     image.setStorageIds(storageIds);
Please remove either this call or the for call
Line 350:                     setDestTypeAndFormat(image);
Line 351:                     diskInfoDestinationMap.put(image.getId(), image);
Line 352:                 }
Line 353:             } else {


-- 
To view, visit http://gerrit.ovirt.org/36553
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia46bef12bbc0462bb42956f95bdff1855631e7b6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvola...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to