Yair Zaslavsky has posted comments on this change. Change subject: core: Add dependency to original sfl4j library ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/32849/1/backend/manager/dependencies/pom.xml File backend/manager/dependencies/pom.xml: Line 18: <name>oVirt Engine dependencies</name> Line 19: Line 20: <modules> Line 21: <module>common</module> Line 22: <module>instance</module> > So should this be named jboss? If so then also we will change the module st I tried posting a comment ,but it didnt work, so if you see it twice, ignore one :) Anyway, maybe it's just me, but when I see both jboss and standalone, I think standalone has to do with the jboss profile of standalone that's we're using, and obviously this is not. I would prefer "ovirt-standalone" (to denote this relate to ovirt ), or "standalone-tools" or "tools" , or something like that :) Line 23: <module>standalone</module> Line 24: </modules> Line 25: -- To view, visit http://gerrit.ovirt.org/32849 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12a3fc298ec3d641e86ea5e766e7e7aa86690b14 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
