Juan Hernandez has posted comments on this change. Change subject: core: Add dependency to original sfl4j library ......................................................................
Patch Set 1: (5 comments) http://gerrit.ovirt.org/#/c/32849/1//COMMIT_MSG Commit Message: Line 6: Line 7: core: Add dependency to original sfl4j library Line 8: Line 9: 1) Adds instance type org.ovirt.slf4j module which will just export Line 10: JBoss reimplementation of slf4j library Why does this module need to be named org.ovirt.slf4j and not org.slf4j like the original one? Line 11: Line 12: 2) Adds standalone type org.ovirt.slf4j module which will provide Line 13: original slf4j-api.jar and slf4j-jdk14.jar so we can use slf4j in Line 14: standalone tools with java.util.logging backend Line 10: JBoss reimplementation of slf4j library Line 11: Line 12: 2) Adds standalone type org.ovirt.slf4j module which will provide Line 13: original slf4j-api.jar and slf4j-jdk14.jar so we can use slf4j in Line 14: standalone tools with java.util.logging backend This should be named org.slf4j, like the original one. Line 15: Line 16: 3) Changes oVirt modules dependency from org.slf4j to org.ovirt.slf4j Line 17: Line 18: 4) Adds dependency to slf4j package Line 12: 2) Adds standalone type org.ovirt.slf4j module which will provide Line 13: original slf4j-api.jar and slf4j-jdk14.jar so we can use slf4j in Line 14: standalone tools with java.util.logging backend Line 15: Line 16: 3) Changes oVirt modules dependency from org.slf4j to org.ovirt.slf4j This change shouldn't be needed. Line 17: Line 18: 4) Adds dependency to slf4j package Line 19: Line 20: Change-Id: I12a3fc298ec3d641e86ea5e766e7e7aa86690b14 http://gerrit.ovirt.org/#/c/32849/1/backend/manager/dependencies/instance/pom.xml File backend/manager/dependencies/instance/pom.xml: Line 21: <groupId>org.slf4j</groupId> Line 22: <artifactId>slf4j-api</artifactId> Line 23: <version>${slf4j.version}</version> Line 24: </dependency> Line 25: </dependencies> This dependency isn't needed, as you aren't including the .jar file. Line 26: Line 27: <build> Line 28: <plugins> Line 29: <plugin> Line 40: <artifactId>slf4j-api</artifactId> Line 41: <moduleName>org.ovirt.slf4j</moduleName> Line 42: <artifactProvided>true</artifactProvided> Line 43: </module> Line 44: </modules> If you aren't including any .jar file in the module then you don't need to include a list of modules here, with the module.xml file is enough. In addition this makes the new "artifactProvided" parameter patch unnecessary. Line 45: </configuration> Line 46: </plugin> Line 47: </plugins> Line 48: </build> -- To view, visit http://gerrit.ovirt.org/32849 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12a3fc298ec3d641e86ea5e766e7e7aa86690b14 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
