Martin Peřina has posted comments on this change. Change subject: core: Add dependency to original sfl4j library ......................................................................
Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/32849/1//COMMIT_MSG Commit Message: Line 6: Line 7: core: Add dependency to original sfl4j library Line 8: Line 9: 1) Adds instance type org.ovirt.slf4j module which will just export Line 10: JBoss reimplementation of slf4j library > Why does this module need to be named org.ovirt.slf4j and not org.slf4j lik Because org.slf4j is standard JBoss module which I just export in instance type of org.ovirt.slf4j: <module xmlns="urn:jboss:module:1.1" name="org.ovirt.slf4j"> <dependencies> <module name="org.slf4j" export="true"/> </dependencies> </module> And standalone version of org.ovirt.slf4j contains original jars instead of JBoss reimplementation: <module xmlns="urn:jboss:module:1.1" name="org.ovirt.slf4j"> <resources> <resource-root path="slf4j-api.jar"/> <resource-root path="slf4j-jdk14.jar"/> </resources> </module> Line 11: Line 12: 2) Adds standalone type org.ovirt.slf4j module which will provide Line 13: original slf4j-api.jar and slf4j-jdk14.jar so we can use slf4j in Line 14: standalone tools with java.util.logging backend http://gerrit.ovirt.org/#/c/32849/1/backend/manager/dependencies/pom.xml File backend/manager/dependencies/pom.xml: Line 18: <name>oVirt Engine dependencies</name> Line 19: Line 20: <modules> Line 21: <module>common</module> Line 22: <module>instance</module> > what is instance? oh! maybe better jboss? webapp? So should this be named jboss? If so then also we will change the module structure to: modules |- common |- jboss |- standalone Do you agree? Line 23: <module>standalone</module> Line 24: </modules> Line 25: http://gerrit.ovirt.org/#/c/32849/1/ovirt-engine.spec.in File ovirt-engine.spec.in: Line 708: common/org/ovirt/otopi/main/otopi.jar otopi/otopi.jar Line 709: common/org/ovirt/ovirt-host-deploy/main/ovirt-host-deploy.jar ovirt-host-deploy/ovirt-host-deploy.jar Line 710: common/org/ovirt/vdsm-jsonrpc-java/main/vdsm-jsonrpc-java-client.jar vdsm-jsonrpc-java/vdsm-jsonrpc-java-client.jar Line 711: standalone/org/ovirt/slf4j/main/slf4j-api.jar slf4j/slf4j-api.jar Line 712: standalone/org/ovirt/slf4j/main/slf4j-jdk14.jar slf4j/slf4j-jdk14.jar > I think that in rhel the jar is prefixed with eap6 or something I tested with slf4j-1.7.7-1.el6.noarch.rpm from ovirt-master-snapshot-static repository which will be used in oVirt. For downstream: slf4j-eap6 depends on slf4j package, which contains /usr/share/java/slf4j-*.jar so we will need downstream only patch to cover this path difference. Line 713: %if 0%{?fedora} Line 714: %if %{fedora} >= 19 Line 715: common/com/mchange/c3p0/main/c3p0.jar Line 716: common/com/woorea/openstack/sdk/main/glance-client.jar openstack-java-sdk/glance-client.jar -- To view, visit http://gerrit.ovirt.org/32849 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12a3fc298ec3d641e86ea5e766e7e7aa86690b14 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
