Alon Bar-Lev has posted comments on this change. Change subject: core: Add dependency to original sfl4j library ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/32849/1/backend/manager/dependencies/pom.xml File backend/manager/dependencies/pom.xml: Line 18: <name>oVirt Engine dependencies</name> Line 19: Line 20: <modules> Line 21: <module>common</module> Line 22: <module>instance</module> what is instance? oh! maybe better jboss? webapp? Line 23: <module>standalone</module> Line 24: </modules> Line 25: http://gerrit.ovirt.org/#/c/32849/1/ovirt-engine.spec.in File ovirt-engine.spec.in: Line 708: common/org/ovirt/otopi/main/otopi.jar otopi/otopi.jar Line 709: common/org/ovirt/ovirt-host-deploy/main/ovirt-host-deploy.jar ovirt-host-deploy/ovirt-host-deploy.jar Line 710: common/org/ovirt/vdsm-jsonrpc-java/main/vdsm-jsonrpc-java-client.jar vdsm-jsonrpc-java/vdsm-jsonrpc-java-client.jar Line 711: standalone/org/ovirt/slf4j/main/slf4j-api.jar slf4j/slf4j-api.jar Line 712: standalone/org/ovirt/slf4j/main/slf4j-jdk14.jar slf4j/slf4j-jdk14.jar I think that in rhel the jar is prefixed with eap6 or something Line 713: %if 0%{?fedora} Line 714: %if %{fedora} >= 19 Line 715: common/com/mchange/c3p0/main/c3p0.jar Line 716: common/com/woorea/openstack/sdk/main/glance-client.jar openstack-java-sdk/glance-client.jar -- To view, visit http://gerrit.ovirt.org/32849 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12a3fc298ec3d641e86ea5e766e7e7aa86690b14 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
