Juan Hernandez has posted comments on this change. Change subject: core: Add dependency to original sfl4j library ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/32849/1//COMMIT_MSG Commit Message: Line 6: Line 7: core: Add dependency to original sfl4j library Line 8: Line 9: 1) Adds instance type org.ovirt.slf4j module which will just export Line 10: JBoss reimplementation of slf4j library > Because org.slf4j is standard JBoss module which I just export in instance But there is no need to rename the modules, as you are adding the "standalone" modules directory to the modules path after the JBoss modules directory, so the module provided by JBoss will be overriden and never used, even if it has the same name. Line 11: Line 12: 2) Adds standalone type org.ovirt.slf4j module which will provide Line 13: original slf4j-api.jar and slf4j-jdk14.jar so we can use slf4j in Line 14: standalone tools with java.util.logging backend -- To view, visit http://gerrit.ovirt.org/32849 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12a3fc298ec3d641e86ea5e766e7e7aa86690b14 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
