Vojtech Szocs has posted comments on this change. Change subject: aaa: Fixing search to search by authz ......................................................................
Patch Set 7: > Yair, please see my comments in ProfileEntry.java regarding the Serializable > stuff. Please scratch my comments about Java serialization in ProfileEntry. I completely forgot that ProfileEntry goes through GWT's emulation of Java serialization mechanism. (What I wrote in my comments was related to classic Java server-side serialization.) Please consider following changes in ProfileEntry: * don't use final fields (as I originally suggested), because GWT RPC will not serialize them (in addition to transient fields) * provide no-arg constructor (can be protected) * setters are not necessary, unless they are required by user code Sorry for the confusion. -- To view, visit http://gerrit.ovirt.org/28722 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1867577a900e2c7a815d443b771e2576bd8aea2 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Ondřej Macháček <machacek.on...@gmail.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
