Yair Zaslavsky has posted comments on this change. Change subject: aaa: Fixing search to search by authz ......................................................................
Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/28722/5/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/AdElementListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/AdElementListModel.java: Line 435: Line 436: return false; Line 437: } Line 438: Line 439: private String extractAuthorizationProvider(ProfileEntry profileEntry) { > right, i iwll remove. Done Line 440: return profileEntry.getAuthz(); Line 441: } Line 442: http://gerrit.ovirt.org/#/c/28722/5/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserPortalAdElementListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserPortalAdElementListModel.java: Line 40: Line 41: private DbUser getTargetDbUser() { Line 42: DbUser dbUser = new DbUser(); Line 43: dbUser.setLoginName(getSearchString()); Line 44: dbUser.setDomain(getProfile().getSelectedItem().toString()); > Good point. Done Line 45: return dbUser; Line 46: } Line 47: Line 48: @Override -- To view, visit http://gerrit.ovirt.org/28722 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1867577a900e2c7a815d443b771e2576bd8aea2 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
