Yair Zaslavsky has posted comments on this change. Change subject: aaa: Fixing search to search by authz ......................................................................
Patch Set 7: (4 comments) http://gerrit.ovirt.org/#/c/28722/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAAAProfileListQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAAAProfileListQuery.java: Line 27: Collections.sort(names, new Comparator<ProfileEntry>() { Line 28: Line 29: @Override Line 30: public int compare(ProfileEntry lhs, ProfileEntry rhs) { Line 31: return lhs.getProfile().compareTo(rhs.getProfile()) == 0 ? > +1 Done Line 32: lhs.getProfile().compareTo(rhs.getProfile()) Line 33: : lhs.getAuthz().compareTo(rhs.getAuthz()); Line 34: Line 35: } http://gerrit.ovirt.org/#/c/28722/7/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/aaa/ProfileEntry.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/aaa/ProfileEntry.java: > Please see my comments in patchset 5, I think we don't need to follow JavaB i saw your comments later on on the GWT serialization, and addressed them. thanks! Line 1: package org.ovirt.engine.core.aaa; Line 2: Line 3: import java.io.Serializable; Line 4: Line 5: public class ProfileEntry implements Serializable { Line 6: Line 7: /** Line 8: * Line 9: */ > Can we remove the above Done Line 10: private static final long serialVersionUID = 8525199877264821199L; Line 11: Line 12: private String profile; Line 13: private String authz; http://gerrit.ovirt.org/#/c/28722/7/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java: Line 3783: public Object Convert(Object source, AsyncQuery _asyncQuery) Line 3784: { Line 3785: List<String> results = new ArrayList<String>(); Line 3786: for (ProfileEntry profileEntry : source != null ? (Collection<ProfileEntry>) source Line 3787: : new ArrayList<ProfileEntry>()) { > probably some copy & paste from other code in AsyncDataProvider :) Done Line 3788: results.add(profileEntry.getProfile()); Line 3789: } Line 3790: return results; Line 3791: } -- To view, visit http://gerrit.ovirt.org/28722 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1867577a900e2c7a815d443b771e2576bd8aea2 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Ondřej Macháček <machacek.on...@gmail.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
