Yair Zaslavsky has posted comments on this change. Change subject: aaa: Fixing search to search by authz ......................................................................
Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/28722/7/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java: Line 3783: public Object Convert(Object source, AsyncQuery _asyncQuery) Line 3784: { Line 3785: List<String> results = new ArrayList<String>(); Line 3786: for (ProfileEntry profileEntry : source != null ? (Collection<ProfileEntry>) source Line 3787: : new ArrayList<ProfileEntry>()) { > Backend does not return null, why do we need a null check here for source? probably some copy & paste from other code in AsyncDataProvider :) Line 3788: results.add(profileEntry.getProfile()); Line 3789: } Line 3790: return results; Line 3791: } -- To view, visit http://gerrit.ovirt.org/28722 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1867577a900e2c7a815d443b771e2576bd8aea2 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Ondřej Macháček <machacek.on...@gmail.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
