Vojtech Szocs has posted comments on this change. Change subject: aaa: Fixing search to search by authz ......................................................................
Patch Set 7: (2 comments) http://gerrit.ovirt.org/#/c/28722/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAAAProfileListQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAAAProfileListQuery.java: Line 27: Collections.sort(names, new Comparator<ProfileEntry>() { Line 28: Line 29: @Override Line 30: public int compare(ProfileEntry lhs, ProfileEntry rhs) { Line 31: return lhs.getProfile().compareTo(rhs.getProfile()) == 0 ? Shouldn't this be != ? :-) Line 32: lhs.getProfile().compareTo(rhs.getProfile()) Line 33: : lhs.getAuthz().compareTo(rhs.getAuthz()); Line 34: Line 35: } http://gerrit.ovirt.org/#/c/28722/7/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/aaa/ProfileEntry.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/aaa/ProfileEntry.java: Please see my comments in patchset 5, I think we don't need to follow JavaBeans convention here. Line 1: package org.ovirt.engine.core.aaa; Line 2: Line 3: import java.io.Serializable; Line 4: -- To view, visit http://gerrit.ovirt.org/28722 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1867577a900e2c7a815d443b771e2576bd8aea2 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Ondřej Macháček <machacek.on...@gmail.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
