Moti Asayag has posted comments on this change. Change subject: core: audit logging support for mac pools. ......................................................................
Patch Set 7: (3 comments) minor comments. http://gerrit.ovirt.org/#/c/29204/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddMacPoolCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddMacPoolCommand.java: Line 64: setSucceeded(true); Line 65: getReturnValue().setActionReturnValue(getMacPoolId()); Line 66: } Line 67: Line 68: //used by introspector Is there an option to add those methods to MacPoolCommandBase and override them in RemoveMacPoolCommand ? Line 69: public Guid getMacPoolId() { Line 70: return getMacPoolEntity().getId(); Line 71: } Line 72: http://gerrit.ovirt.org/#/c/29204/7/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AuditLog.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AuditLog.java: Line 9: import org.ovirt.engine.core.compat.Guid; Line 10: Line 11: public class AuditLog extends IVdcQueryable implements Serializable { Line 12: private static final long serialVersionUID = -5346124122179332184L; Line 13: please remove this change from the patch. Line 14: private long auditLogId; Line 15: private Date logTime; Line 16: private String message; Line 17: private Guid userId; http://gerrit.ovirt.org/#/c/29204/7/backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties File backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties: Line 835: KDUMP_FLOW_DETECTED_ON_VDS=Kdump flow detected on host '${VdsName}'. Line 836: KDUMP_FLOW_NOT_DETECTED_ON_VDS=Kdump flow not detected on host '${VdsName}'. Line 837: KDUMP_FLOW_FINISHED_ON_VDS=Kdump flow finished on host '${VdsName}'. Line 838: KDUMP_DETECTION_NOT_CONFIGURED_ON_VDS=Kdump detection is enabled for host '${VdsName}', but kdump is not configured properly on host. Line 839: s/created/was created ? if agreed, same change should go to other messages (was changed, was removed) Please add (User: ${UserName}) at the end of the messages, so the log will include the user who executed it. Line 840: MAC_POOL_ADD_SUCCESS=MAC Pool '${MacPoolName}' (id=${MacPoolId}) created. Line 841: MAC_POOL_ADD_FAILED=Failed to create MAC Pool '${MacPoolName}'. Line 842: MAC_POOL_EDIT_SUCCESS=MAC Pool '${MacPoolName}' (id=${MacPoolId}) changed. Line 843: MAC_POOL_EDIT_FAILED=Failed to update MAC Pool '${MacPoolName}' (id=${MacPoolId}). -- To view, visit http://gerrit.ovirt.org/29204 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I376b89abc03657a7cd2eb1b06e21591e4cd944ad Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
