Moti Asayag has posted comments on this change. Change subject: core: audit logging support for mac pools. ......................................................................
Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/29204/5/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java: Line 90: private Guid quotaIdForLog; Line 91: private String quotaNameForLog; Line 92: private String callStack; Line 93: private String macPoolNameForLog; Line 94: private Guid macPoolIdForLog; > Code in this patch tried to follow feature page as precisely as possible. I was under the assumption that you figured out how AuditLogDirector works, mainly since you sent a patch to refactor it and it touched the relevant lines (line 168 on http://gerrit.ovirt.org/#/c/29244/4/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java,cm). I wasn't able to find any section about logging in the feature page. The resolve of the property is executed in that class - drill down in AuditLogDirector.resolveMessage() --> AuditLogDirector.getAvailableValues() --> TypeCompat.getPropertyValues(...) There is were the bean introspection happens and properties are resolved. Line 95: Line 96: public AuditLogableBase() { Line 97: } Line 98: http://gerrit.ovirt.org/#/c/29204/5/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AuditLogDAODbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AuditLogDAODbFacadeImpl.java: Line 138: .addValue("gluster_volume_id", event.getGlusterVolumeId()) Line 139: .addValue("gluster_volume_name", event.getGlusterVolumeName()) Line 140: .addValue("call_stack", event.getCallStack()) Line 141: .addValue("mac_pool_id", event.getMacPoolId()) Line 142: .addValue("mac_pool_name", event.getMacPoolName()); > please explain, why's that, where these values will be saved to. As I said can you refer me to a paragraph in the feature page which describes the extension of the audit-log table ? i wasn't able to find any. the audit-log table used for storing events, both for clients queries, or for subscribing for a specific event in the system. 1. the audit-log type saves the translated message. 2. there are no notifications planned for mac pool actions (and even there was such case, i guess the message itself should be sufficient). hence there is no need to store those values in the db. Line 143: } Line 144: Line 145: private MapSqlParameterSource getExternalEventSqlMapper(AuditLog event) { Line 146: return getSqlMapper(event) -- To view, visit http://gerrit.ovirt.org/29204 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I376b89abc03657a7cd2eb1b06e21591e4cd944ad Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
