Martin Mucha has posted comments on this change. Change subject: core: audit logging support for mac pools. ......................................................................
Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/29204/5/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java: Line 90: private Guid quotaIdForLog; Line 91: private String quotaNameForLog; Line 92: private String callStack; Line 93: private String macPoolNameForLog; Line 94: private Guid macPoolIdForLog; > there is no reason to extend this class with those fields. Code in this patch tried to follow feature page as precisely as possible. Please explain given example. How this work??? There's no obvious link between ${VnicProfileName} in resource bundle and method VnicProfileCommandBase.getVnicProfileName(). IDE's reporting (if it's not mistaken) that this method is not used, and I did not find any reflect magic. Line 95: Line 96: public AuditLogableBase() { Line 97: } Line 98: http://gerrit.ovirt.org/#/c/29204/5/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AuditLogDAODbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AuditLogDAODbFacadeImpl.java: Line 138: .addValue("gluster_volume_id", event.getGlusterVolumeId()) Line 139: .addValue("gluster_volume_name", event.getGlusterVolumeName()) Line 140: .addValue("call_stack", event.getCallStack()) Line 141: .addValue("mac_pool_id", event.getMacPoolId()) Line 142: .addValue("mac_pool_name", event.getMacPoolName()); > extending this table isn't required. please explain, why's that, where these values will be saved to. As I said feature page explicitly mention need of db columns creation. If that not the case, how this work then? Line 143: } Line 144: Line 145: private MapSqlParameterSource getExternalEventSqlMapper(AuditLog event) { Line 146: return getSqlMapper(event) -- To view, visit http://gerrit.ovirt.org/29204 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I376b89abc03657a7cd2eb1b06e21591e4cd944ad Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
