Martin Mucha has posted comments on this change. Change subject: core: audit logging support for mac pools. ......................................................................
Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/29204/7/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AuditLog.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AuditLog.java: Line 9: import org.ovirt.engine.core.compat.Guid; Line 10: Line 11: public class AuditLog extends IVdcQueryable implements Serializable { Line 12: private static final long serialVersionUID = -5346124122179332184L; Line 13: > why is this change relevant to this patch ? nah, I'm an asshole. I've already realized I'm wrong this morning while shaving — this change was OK, but it should went away with removal of unnecessary fields. I overlooked that these two changes are linked together. I'll revert it. Line 14: private long auditLogId; Line 15: private Date logTime; Line 16: private String message; Line 17: private Guid userId; -- To view, visit http://gerrit.ovirt.org/29204 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I376b89abc03657a7cd2eb1b06e21591e4cd944ad Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
