Moti Asayag has posted comments on this change.

Change subject: core: audit logging support for mac pools.
......................................................................


Patch Set 5:

The convention of the audit log messages for a failed action is:

"Failed to XXX"

 or

"Entity EntityName was updated/added/removed by user..."

this is the majority of the messages and we should comply with:

this is just one example so we have context to what audit log message is 
usually looks alike:

USER_ADD_STORAGE_POOL=Data Center ${StoragePoolName}, Compatibility Version 
${CompatibilityVersion} and Quota Type ${QuotaEnforcementType} was added by 
${UserName}
USER_ADD_STORAGE_POOL_FAILED=Failed to add Data Center ${StoragePoolName}. 
(User: ${UserName})

-- 
To view, visit http://gerrit.ovirt.org/29204
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I376b89abc03657a7cd2eb1b06e21591e4cd944ad
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmu...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to