Alon Bar-Lev has posted comments on this change.

Change subject: aaa: Changes to ExtensionsManager
......................................................................


Patch Set 22:

(1 comment)

http://gerrit.ovirt.org/#/c/27785/22/backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java
File 
backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java:

Line 253:                             ).mput(
Line 254:                                     Base.ExtensionRecord.CONTEXT,
Line 255:                                     entry.extension.getContext()
Line 256:                             )
Line 257:                     );
> hmmm:
what about initialize the global at initialization?
Line 258:         }
Line 259:         loadedEntries.putIfAbsent(entry.name, entry);
Line 260:         setChanged();
Line 261:         notifyObservers();


-- 
To view, visit http://gerrit.ovirt.org/27785
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c914df29a0dbf52ff6d2f8149687b31b4faffe1
Gerrit-PatchSet: 22
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to