Alon Bar-Lev has posted comments on this change. Change subject: aaa: Changes to ExtensionsManager ......................................................................
Patch Set 20: (1 comment) http://gerrit.ovirt.org/#/c/27785/20/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/extensionsmgr/EngineExtensionsManager.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/extensionsmgr/EngineExtensionsManager.java: Line 71: instance.activate( Line 72: extension.getContext().<String> get(Base.ContextKeys.INSTANCE_NAME), Line 73: EngineLocalConfig.getInstance().getBoolean( Line 74: ENGINE_EXTENSION_ENABLED + extension.getContext().<String> get(Base.ContextKeys.INSTANCE_NAME) Line 75: ) > and have the logic that checks the entry at engine config vs the properties I do not follow... what we want to know is if extension is enabled or not at its configuration to know if we want to override the configuration and activate it anyway. so you added an overwrite... which will work, but I do not think it is intuitive. maybe have two lists of these are loaded and these are initialized? and be able to get extensions from loaded and ask for their requested status? Line 76: ); Line 77: } catch (Exception ex) { Line 78: log.error(ex.getMessage()); Line 79: log.debug(ex); -- To view, visit http://gerrit.ovirt.org/27785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c914df29a0dbf52ff6d2f8149687b31b4faffe1 Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
