Yair Zaslavsky has posted comments on this change. Change subject: aaa: Changes to ExtensionsManager ......................................................................
Patch Set 22: (3 comments) http://gerrit.ovirt.org/#/c/27785/22/backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java File backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java: Line 219: getTraceLog(), Line 220: entry.extension.getContext().get(Base.ContextKeys.EXTENSION_NAME), Line 221: entry.extension.getContext().get(Base.ContextKeys.INSTANCE_NAME) Line 222: ) Line 223: ) > I do not want to skip the name as I would like a way to enable all logging I am not sure we will not care what instance there are, the ExtMaps contain "per instance" information - for example, name of principal to query. I will move for now after the load. Line 224: ); Line 225: Line 226: ExtMap output = entry.extension.invoke( Line 227: new ExtMap().mput( Line 253: ).mput( Line 254: Base.ExtensionRecord.CONTEXT, Line 255: entry.extension.getContext() Line 256: ) Line 257: ); > hmmm: Done Line 258: } Line 259: loadedEntries.putIfAbsent(entry.name, entry); Line 260: setChanged(); Line 261: notifyObservers(); Line 309: public ExtensionProxy initialize(String extensionName) { Line 310: ExtensionEntry entry = loadedEntries.get(extensionName); Line 311: if (entry == null) { Line 312: throw new RuntimeException(String.format("No extensioned with instance name %1$s could be found", Line 313: extensionName)); > at least the get by name? whatever you have there condition of == null well, this is a get from a map. getExtensionByName returns an initialized extension. We can add getLoadedExtensionByName ... not sure if that worth. what do u think? Line 314: } Line 315: try { Line 316: ExtMap output = entry.extension.invoke( Line 317: new ExtMap().mput( -- To view, visit http://gerrit.ovirt.org/27785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c914df29a0dbf52ff6d2f8149687b31b4faffe1 Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
