Alon Bar-Lev has posted comments on this change. Change subject: aaa: Changes to ExtensionsManager ......................................................................
Patch Set 22: (2 comments) http://gerrit.ovirt.org/#/c/27785/22/backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java File backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java: Line 219: getTraceLog(), Line 220: entry.extension.getContext().get(Base.ContextKeys.EXTENSION_NAME), Line 221: entry.extension.getContext().get(Base.ContextKeys.INSTANCE_NAME) Line 222: ) Line 223: ) > I am not sure we will not care what instance there are, the ExtMaps contain we will... but as 2nd level... so we enable log as: generic-ldap.domain1 for domain1, but we can still enable logs as generic-ldap to see all Line 224: ); Line 225: Line 226: ExtMap output = entry.extension.invoke( Line 227: new ExtMap().mput( Line 309: public ExtensionProxy initialize(String extensionName) { Line 310: ExtensionEntry entry = loadedEntries.get(extensionName); Line 311: if (entry == null) { Line 312: throw new RuntimeException(String.format("No extensioned with instance name %1$s could be found", Line 313: extensionName)); > well, this is a get from a map. not worth for now. Line 314: } Line 315: try { Line 316: ExtMap output = entry.extension.invoke( Line 317: new ExtMap().mput( -- To view, visit http://gerrit.ovirt.org/27785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c914df29a0dbf52ff6d2f8149687b31b4faffe1 Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
