Alon Bar-Lev has posted comments on this change. Change subject: aaa: Changes to ExtensionsManager ......................................................................
Patch Set 24: (2 comments) last comments! http://gerrit.ovirt.org/#/c/27785/24/backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java File backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java: Line 312: if (log.isDebugEnabled()) { Line 313: log.debug(ex.toString(), ex); Line 314: } Line 315: throw new RuntimeException(ex); Line 316: } we the try is not on the entire function? not critical, but just a question. Line 317: entry.initialized = true; Line 318: initializedEntries.put(extensionName, entry); Line 319: synchronized (globalContext) { Line 320: globalContext.<List<ExtMap>> get(Base.GlobalContextKeys.EXTENSIONS).add( Line 332: entry.extension.getContext() Line 333: ) Line 334: ); Line 335: } Line 336: dumpConfig(entry.extension); should we do this after load? at both places only after load? Line 337: setChanged(); Line 338: notifyObservers(); Line 339: return entry != null ? entry.extension : null; Line 340: } -- To view, visit http://gerrit.ovirt.org/27785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c914df29a0dbf52ff6d2f8149687b31b4faffe1 Gerrit-PatchSet: 24 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
