Michael Pasternak has posted comments on this change.
Change subject: rest: Add Port Mirroring to VM interface
......................................................................
Patch Set 24: I would prefer that you didn't submit this
(4 inline comments)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmNicResource.java
Line 52:
device.getPortMirroring().getNetworks().getNetworks().get(0).isSetId()
this is inconsistent, in NicMapper i see that when mirroring enabled, you
set network_name (backend->client), here you expect user to set network_id
for you (client->backend),
i think any user seeing that in nic X in port mirroring appears network name,
and he wants to enable mirroring in nic Y, will do the same - will set
network_name
while your code not ready for this,
i vote for nic_id on both directions.
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmNicsResource.java
Line 69: &&
same comment as in BackendVmNicResource.java
....................................................
File
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NicMapper.java
Line 76: net.setName(entity.getNetworkName());
here you set network_name instead of id ....
....................................................
Commit Message
Line 17: <network href="/api/networks/{network-id}"
id="{network-id}"/>
you not supplying id right? only name ...
--
To view, visit http://gerrit.ovirt.org/3727
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic03d841d6d0f6cb7250a25e43bdda3d3e9b7488b
Gerrit-PatchSet: 24
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: Livnat Peer <lp...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Ori Liel <ol...@redhat.com>
Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
