Shahar Havivi has posted comments on this change.
Change subject: rest: Add Port Mirroring to VM interface
......................................................................
Patch Set 19: (3 inline comments)
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
Line 2157: <xs:element ref="port_mirroring" minOccurs="0"
maxOccurs="1"/>
Michael,
I did send a patch with that design but you revert me to the original design,
the commit message is wrong, its as the previous patch and I will change it
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml
Line 325: optionalArguments: {nic.network.id|name: 'xs:string',
nic.name: 'xs:string', nic.port_mirroring--COLLECTION:
{port_mirroring.network.name: 'xs:string'}}
no,
you ack me on
<nic>
...
<network href="/api/networks/{network-id}" id="{network-id}"/>
<port-mirroring>
<network href="/api/networks/{network-id}" id="{network-id}"/>
....
</port mirroring>
</nic>
my previous patch was like that and you told me that this is not the original
design,
maybe the yaml is wrong so please tell me if it is,
the commit message is wrong because its align to the previous patch
....................................................
File
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NicMapper.java
Line 71: net.setName(entity.getNetworkName());
but we are setting the network by id
--
To view, visit http://gerrit.ovirt.org/3727
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic03d841d6d0f6cb7250a25e43bdda3d3e9b7488b
Gerrit-PatchSet: 19
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: Livnat Peer <lp...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Ori Liel <ol...@redhat.com>
Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
