Michael Pasternak has posted comments on this change. Change subject: rest: Add Port Mirroring to VM interface ......................................................................
Patch Set 19: (1 inline comment) .................................................... File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd Line 2157: <xs:element ref="port_mirroring" minOccurs="0" maxOccurs="1"/> i know man, but then you told that you have to add extra metadata to port_mirroring, remember? this way you have to have collection of <port_mirrorings> <port_mirroring> <network> </network> <xxx>...</xxx> </port_mirroring> <port_mirroring> <network> </network> <xxx>...</xxx> </port_mirroring> ... </port_mirrorings> if you regret, it's fine by me, but remember you cannot change it for next 3 versions .... -- To view, visit http://gerrit.ovirt.org/3727 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic03d841d6d0f6cb7250a25e43bdda3d3e9b7488b Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
