Shahar Havivi has posted comments on this change.

Change subject: rest: Add Port Mirroring to VM interface
......................................................................


Patch Set 25: (5 inline comments)

....................................................
File 
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml
Line 325:         optionalArguments: {nic.network.id|name: 'xs:string', 
nic.name: 'xs:string', nic.mac.address: 'xs:string', nic.interface: 
'xs:string', nic.port_mirroring--COLLECTION: {port_mirroring.network.name: 
'xs:string'}}
Done

Line 348:         optionalArguments: {nic.mac.address: 'xs:string', 
nic.interface: 'xs:string', nic.port_mirroring--COLLECTION: 
{port_mirroring.network.name: 'xs:string'}}
Done

....................................................
File 
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmNicResource.java
Line 41:         }
Done

....................................................
File 
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmNicsResource.java
Line 31: public class BackendVmNicsResource
Done

....................................................
File 
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NicMapper.java
Line 72:         if (entity.isPortMirroring()) {
Done

--
To view, visit http://gerrit.ovirt.org/3727
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic03d841d6d0f6cb7250a25e43bdda3d3e9b7488b
Gerrit-PatchSet: 25
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: Livnat Peer <lp...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Ori Liel <ol...@redhat.com>
Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to