Shahar Havivi has posted comments on this change.
Change subject: rest: Add Port Mirroring to VM interface
......................................................................
Patch Set 19: (6 inline comments)
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
Line 2157: <xs:element ref="port_mirroring" minOccurs="0"
maxOccurs="1"/>
I didn't state that on the commit message I did state that there is one network:
4 ...
15 <ports_mirroring>
16 <port_mirroring>
17 <network href="/api/networks/{network-id}"
id="{network-id}"/>
18 </port_mirroring>
19 </ports_mirroring>
when the engine will support that we will change the number in this xsd to
support:
4 ...
15 <ports_mirroring>
16 <port_mirroring>
17 <network href="/api/networks/{network-id}"
id="{network-id}"/>
17 <network href="/api/networks/{network-id}"
id="{network-id}"/>
17 <network href="/api/networks/{network-id}"
id="{network-id}"/>
18 </port_mirroring>
19 </ports_mirroring>
I don't see any reason to add that now
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml
Line 325: optionalArguments: {nic.network.id|name: 'xs:string',
nic.name: 'xs:string', nic.port_mirroring--COLLECTION:
{port_mirroring.network.name: 'xs:string'}}
1. there is no ports_mirroring anymore
2. will fix it
Line 348: optionalArguments: {nic.network.id|name: 'xs:string',
nic.name: 'xs:string', nic.port_mirroring--COLLECTION:
{port_mirroring.network.name: 'xs:string'}}
1. there is no ports_mirroring anymore
2. will fix it
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmNicResource.java
Line 57: throw new WebApplicationException(response);
look at the todo,
this is the idea for this change in the last patch...
the backend is getting only true/false for the port mirroring, but in rest we
support for the next version to avoid supporting backward comparability.
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmNicsResource.java
Line 74: }
look at the todo,
this is the idea for this change in the last patch...
the backend is getting only true/false for the port mirroring, but in rest we
support for the next version to avoid supporting backward comparability.
....................................................
File
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NicMapper.java
Line 71: net.setName(entity.getNetworkName());
right,
but NIC has no NetworkId!, because the VmNetworkInterface have no getNetworkId.
I was told not to use queries in the mapper.
--
To view, visit http://gerrit.ovirt.org/3727
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic03d841d6d0f6cb7250a25e43bdda3d3e9b7488b
Gerrit-PatchSet: 19
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: Livnat Peer <lp...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Ori Liel <ol...@redhat.com>
Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
