Allon Mureinik has posted comments on this change.
Change subject: core: Added GetManagementInterfaceAddressByVdsId query
......................................................................
Patch Set 2: (4 inline comments)
....................................................
File backend/manager/dbscripts/network_sp.sql
Line 320: FROM vds_interface_view
Please document this bitwise operation.
it's not really intuitive.
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/InterfaceDAODbFacadeImpl.java
Line 162: static final ParameterizedRowMapper<VdsNetworkInterface>
vdsNetworkInterfaceRowMapper =
Make this method private.
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/InterfaceDAO.java
Line 90: VdsNetworkInterface getManagedInterfaceForVdsByVdsId(Guid id, Guid
userID, boolean isFiltered);
Please follow the class' convention: getManagedInterfaceForVds
....................................................
File
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/InterfaceDAOTest.java
Line 281: private void
assertCorrectGetManagedInterfaceForVdsResult(VdsNetworkInterface result) {
You can make this method private
--
To view, visit http://gerrit.ovirt.org/4854
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6d855734c6cdec937de6ec91d1c80a23333eec8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
