Allon Mureinik has posted comments on this change.
Change subject: core: Added GetManagementInterfaceAddressByVdsId query
......................................................................
Patch Set 5: Looks good to me, but someone else must approve
(1 inline comment)
a minor comment, see inline.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetManagementInterfaceAddressByVdsIdQuery.java
Line 18:
the return value is null unless you set it.
I'd do the followinf:
if (nic != null) {
getQueryReturnValue().setReturnValue(nic.getAddress());
}
but it's a matter of taste
--
To view, visit http://gerrit.ovirt.org/4854
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6d855734c6cdec937de6ec91d1c80a23333eec8
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
