Itamar Heim has posted comments on this change. Change subject: core: Added GetManagementInterfaceAddressByVdsId query ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/dbscripts/network_sp.sql Line 321: WHERE vds_id = v_vds_id AND (type & 2) = 2 I'd add a comment explaining the logic of (type & 2) = 2 is meant to cover -- To view, visit http://gerrit.ovirt.org/4854 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic6d855734c6cdec937de6ec91d1c80a23333eec8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
