Shahar Havivi has posted comments on this change. Change subject: rest: Add Port Mirroring to VM interface ......................................................................
Patch Set 15: (1 inline comment) .................................................... Commit Message Line 21: You are right... but this model is actually what we need, because port_mirroring will have more attributes such as type: <nic> <ports_mirroring> <port_mirroring> <type>mirror</type> <network> <name>red</name> </network> </port_mirroring> <port_mirroring> <type>redirect</type> <network> <name>blue</name> </network> </port_mirroring> </ports_mirroring> </nic> -- To view, visit http://gerrit.ovirt.org/3727 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic03d841d6d0f6cb7250a25e43bdda3d3e9b7488b Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches