Arik Hadas has posted comments on this change. Change subject: core: remove RunVmCommandBase#getDestinationVds ......................................................................
Patch Set 7: (2 comments) http://gerrit.ovirt.org/#/c/24255/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java: Line 111: setStoragePoolId(getVm() != null ? getVm().getStoragePoolId() : null); Line 112: initRunVmCommand(); Line 113: } Line 114: Line 115: protected Guid getPredefinedVdsIdToRunOn() { > are you sure the previous getter name is not used in any audit log messages yes. getDestinationVdsName is used by the audit messages (and I didn't see any audit message that mention the UID of the host) Line 116: return getVm().getDedicatedVmForVds(); Line 117: } Line 118: Line 119: private void initRunVmCommand() { http://gerrit.ovirt.org/#/c/24255/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java: Line 57: } Line 58: Line 59: @Override Line 60: protected Guid getPredefinedVdsIdToRunOn() { Line 61: // destination VDS ID is stronger than the dedicated VDS > s/is stornger than/has priority over/ Done Line 62: return getParameters().getDestinationVdsId() != null ? Line 63: getParameters().getDestinationVdsId() Line 64: : super.getPredefinedVdsIdToRunOn(); Line 65: } -- To view, visit http://gerrit.ovirt.org/24255 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1d8fb852a88203378b3bcd3f1d6f96e469e5cb9 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
