Roy Golan has posted comments on this change. Change subject: core: remove RunVmCommandBase#getDestinationVds ......................................................................
Patch Set 3: (3 comments) http://gerrit.ovirt.org/#/c/24255/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java: Line 73: destinationVdsId wouldn't adding this be simpler instead of rewriting? (original if) || !chachedDestVdsId.equlas(destinationVdsId) 1 caveat is the roundrip to db incase destVdsId is null. we could work this out as well http://gerrit.ovirt.org/#/c/24255/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java: Line 113: getPredefinedDestinationVdsId either call this metod getDedicatedVdsId or remove it completely. its just adding confusion Line 614: getPredefinedDestinationVdsId same here. predefinedDestinationVds isn't any clearer than destinationVds -- To view, visit http://gerrit.ovirt.org/24255 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1d8fb852a88203378b3bcd3f1d6f96e469e5cb9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
