Arik Hadas has submitted this change and it was merged. Change subject: core: remove RunVmCommandBase#getDestinationVds ......................................................................
core: remove RunVmCommandBase#getDestinationVds In light of 84fc3c7 RunVmCommandBase#getDestinationVds is now used only by classes which extend RunVmCommandBase and is used differently: MigrateVm returns the VDS that the VM is going to migrate to, RunVm & RunVmOnce return the predefined VDS on which the VM should run on. This patch removes RunVmCommandBase#getDestinationVds method. In RunVm it is replaced by getPredefinedDestinationVdsId method which reflect the result better by its name and returns only the ID of the VDS. In addition, minor improvement was made in MigrateVmCommand#getDestinationVds, and calls to it where we only need the ID of the VDS were replaced by calls to MigrateVmCommand#getDestinationVdsId. Change-Id: Ie1d8fb852a88203378b3bcd3f1d6f96e469e5cb9 Signed-off-by: Arik Hadas <aha...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java 4 files changed, 31 insertions(+), 56 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24255 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie1d8fb852a88203378b3bcd3f1d6f96e469e5cb9 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
