Arik Hadas has posted comments on this change. Change subject: core: remove RunVmCommandBase#getDestinationVds ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/24255/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java: Line 69: .TranslateErrorTextSingle(migrationErrorCode.name(), true); Line 70: } Line 71: Line 72: protected VDS getDestinationVds() { Line 73: if (destinationVdsId == null) { > why is it be better to do this check in the DAO level and not in this comma It was changed according to omer's suggestion, please review again Line 74: return cachedDestinationVds = null; Line 75: } Line 76: Line 77: if (cachedDestinationVds == null || !cachedDestinationVds.getId().equals(destinationVdsId)) { http://gerrit.ovirt.org/#/c/24255/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java: Line 113: getPredefinedDestinationVdsId > but it doesn't always return the dedicated vds. in run vm once flow, it ret if changing the name is ok then Done (changed to getPredefinedVdsIdToRunOn, I agree that the previous name was not the best to select) -- To view, visit http://gerrit.ovirt.org/24255 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1d8fb852a88203378b3bcd3f1d6f96e469e5cb9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
