Gilad Chaplik has posted comments on this change. Change subject: core: remove RunVmCommandBase#getDestinationVds ......................................................................
Patch Set 4: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/24255/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java: Line 70: } Line 71: Line 72: protected VDS getDestinationVds() { Line 73: if (destinationVdsId == null) { Line 74: return cachedDestinationVds = null; can you split to 2 lines? Line 75: } Line 76: Line 77: if (cachedDestinationVds == null || !cachedDestinationVds.getId().equals(destinationVdsId)) { Line 78: cachedDestinationVds = getVdsDAO().get(destinationVdsId); -- To view, visit http://gerrit.ovirt.org/24255 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1d8fb852a88203378b3bcd3f1d6f96e469e5cb9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
