Alon Bar-Lev has posted comments on this change.

Change subject: 6. [WIP] core: Introducing AuthenticationProfileRepository
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.ovirt.org/#/c/24366/4/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticationProfileRepository.java
File 
backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticationProfileRepository.java:

Line 40:         // (authentication)
Line 41:         // objects into a profile object.
Line 42: 
Line 43:         List<ExtensionEntry> authnExtensions = 
ConfigurationLoader.getInstance().getExtensionsByService(AUTHN_SERVICE);
Line 44:         List<ExtensionEntry> authzExtensions = 
ConfigurationLoader.getInstance().getExtensionsByService(AUTHZ_SERVICE);
> Hi, I am following the example you published at myipa-authn.properties.
hmm... you are right!

the link between authn and authz should be based on plugin name...

the profile name is what the authn has.
Line 45:         Map<String, ExtensionEntry> authnMap = new HashMap<>();
Line 46:         Map<String, ExtensionEntry> authzMap = new HashMap<>();
Line 47: 
Line 48:         if (authnExtensions != null) {


-- 
To view, visit http://gerrit.ovirt.org/24366
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If375fccea98544c64d9ec41cc9dbcb855bf02fb7
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to