Yair Zaslavsky has posted comments on this change. Change subject: 5. [WIP] core: Introducing AuthenticationProfileRepository ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/24366/2/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticationProfileRepository.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticationProfileRepository.java: Line 19: private static AuthenticationProfileRepository instance = null; Line 20: private Map<String, AuthenticationProfile> profiles = new HashMap<String, AuthenticationProfile>(); Line 21: Line 22: static { Line 23: instance = new AuthenticationProfileRepository(); Don't use here a static block, iniitalize it at getInstance() Line 24: } Line 25: Line 26: public static AuthenticationProfileRepository getInstance() { Line 27: return instance; -- To view, visit http://gerrit.ovirt.org/24366 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If375fccea98544c64d9ec41cc9dbcb855bf02fb7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
