Alon Bar-Lev has posted comments on this change. Change subject: 6. [WIP] core: Introducing AuthenticationProfileRepository ......................................................................
Patch Set 4: (3 comments) http://gerrit.ovirt.org/#/c/24366/4/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticationProfileRepository.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticationProfileRepository.java: Line 40: // (authentication) Line 41: // objects into a profile object. Line 42: Line 43: List<ExtensionEntry> authnExtensions = ConfigurationLoader.getInstance().getExtensionsByService(AUTHN_SERVICE); Line 44: List<ExtensionEntry> authzExtensions = ConfigurationLoader.getInstance().getExtensionsByService(AUTHZ_SERVICE); no need... you will acquire one by name, per what authn is referring to. Line 45: Map<String, ExtensionEntry> authnMap = new HashMap<>(); Line 46: Map<String, ExtensionEntry> authzMap = new HashMap<>(); Line 47: Line 48: if (authnExtensions != null) { Line 46: Map<String, ExtensionEntry> authzMap = new HashMap<>(); Line 47: Line 48: if (authnExtensions != null) { Line 49: for (ExtensionEntry entry : authnExtensions) { Line 50: authnMap.put(entry.getConfig().getString(AUTHN_PROFILE), entry); for each also pull the referenced authz, and construct Directory and such here... why do you need the maps? Line 51: } Line 52: } Line 53: Line 54: if (authzExtensions != null) { Line 54: if (authzExtensions != null) { Line 55: for (ExtensionEntry entry : authzExtensions) { Line 56: authzMap.put(entry.getConfig().getString(AUTHZ_PROFILE), entry); Line 57: } Line 58: } no need Line 59: Line 60: for (Map.Entry<String, ExtensionEntry> mapEntry : authnMap.entrySet()) { Line 61: ExtensionEntry authzEntry = authzMap.get(mapEntry.getKey()); Line 62: if (authzEntry != null) { -- To view, visit http://gerrit.ovirt.org/24366 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If375fccea98544c64d9ec41cc9dbcb855bf02fb7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
