Yair Zaslavsky has posted comments on this change. Change subject: 5. [WIP] core: Introducing AuthenticationProfileRepository ......................................................................
Patch Set 2: Regarding your question - 1. ConfigurationLoader loads all the configurations of the extensions 2. The configurations are then used in this class to create AuthenticationProfile objects which couple Directory and Authenticator - since both authn and authz have the profile.name property I couple those with the same value of propfile.name. The reason I prefered not to do that at the ConfigurationLoader is that the ConfigurationLoader belongs to extension-manager module, and IMHO should not have any knowledge about terms like Directory, Authenticator, and AAA in genera, so I prefered having a class in the aaa module that will perform this. -- To view, visit http://gerrit.ovirt.org/24366 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If375fccea98544c64d9ec41cc9dbcb855bf02fb7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
