Alon Bar-Lev has posted comments on this change. Change subject: 5. [WIP] core: Introducing AuthenticationProfileRepository ......................................................................
Patch Set 2: (2 comments) OK, I completely lost. Why do we need this class? Why not have a method within the loader to get an extension by name, and when authentication is loaded it will look up the directory based on the name within its configuration? This class has no benefit as far as I understand, and it creates dependency between authentication and authorization. http://gerrit.ovirt.org/#/c/24366/2/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticationProfileRepository.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticationProfileRepository.java: Line 12: Line 13: private static final String AUTHZ_PROFILE_NAME = "ovirt.engine.aaa.authz.profile.name"; Line 14: private static final String AUTHN_PROFILE_NAME = "ovirt.engine.aaa.authn.profile.name"; Line 15: private static final String AUTHZ_SERVICE_NAME = "org.ovirt.engine.core.authorization"; Line 16: private static final String AUTHN_SERVICE_NAME = "org.ovirt.engine.core.authentication"; if you use enum in previous patch, why do you use constants in this one? Line 17: Line 18: Line 19: private static AuthenticationProfileRepository instance = null; Line 20: private Map<String, AuthenticationProfile> profiles = new HashMap<String, AuthenticationProfile>(); Line 24: } Line 25: Line 26: public static AuthenticationProfileRepository getInstance() { Line 27: return instance; Line 28: } I do not understand the above two... but for ut it will be hell. Line 29: Line 30: public void parseConfigurations(List<Configuration> configurations) { Line 31: Map<String, Directory> directoryMap = new HashMap<>(); Line 32: Map<String, Authenticator> authenticatorMap = new HashMap<String, Authenticator>(); -- To view, visit http://gerrit.ovirt.org/24366 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If375fccea98544c64d9ec41cc9dbcb855bf02fb7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
