Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: update firewall for all services ......................................................................
Patch Set 8: (2 comments) .................................................... File packaging/setup/ovirt_engine_setup/constants.py Line 704: @util.export Line 705: @util.codegen Line 706: class FwManagers(object): Line 707: IPTABLES = 'iptables' Line 708: FIREWALLD = 'firewalld' put in Constants? Line 709: Line 710: Line 711: @util.export Line 712: @util.codegen .................................................... File packaging/setup/plugins/ovirt-engine-setup/network/firewall_manager.py Line 115: osetupcons.ConfigEnv.SUPPORTED_FIREWALL_MANAGERS, Line 116: '%s,%s' % ( Line 117: osetupcons.FwManagers.FIREWALLD, Line 118: osetupcons.FwManagers.IPTABLES, Line 119: ) ','.join(x, y) ? Line 120: ) Line 121: self.environment.setdefault( Line 122: osetupcons.NetEnv.FIREWALLD_SERVICES, Line 123: [] -- To view, visit http://gerrit.ovirt.org/20737 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3c1a634b2e8539ebd604205b5487290c8d8a1a9 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
