Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: update firewall for all services
......................................................................
Patch Set 7:
(1 comment)
....................................................
File packaging/setup/plugins/ovirt-engine-setup/network/firewall_manager.py
Line 168: active_managers.append(manager)
Line 169:
Line 170: if (
Line 171: self.environment[osetupcons.ConfigEnv.UPDATE_FIREWALL] is
None and
Line 172: managers
I still do not understand.
supported = anything we support, default is iptables, firewalld
available = anything that can be configured = supported - whatever active
selected = whatever user selected out of available
if apply_firewall and selected == None:
selected = ask to select from available
if selected == None:
show instruction for available
why is it more complex than above?
Line 173: ):
Line 174: self.dialog.note(
Line 175: text=_(
Line 176: 'Setup can automatically configure the firewall '
--
To view, visit http://gerrit.ovirt.org/20737
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3c1a634b2e8539ebd604205b5487290c8d8a1a9
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
