Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: update firewall for all services ......................................................................
Patch Set 6: (1 comment) what about print the manual instructions to firewalls specified in the enabled managers? .................................................... File packaging/setup/plugins/ovirt-engine-setup/network/firewall_manager.py Line 191: Line 192: if ( Line 193: self.environment[osetupcons.ConfigEnv.FIREWALL_MANAGER] is None and Line 194: self.environment[osetupcons.ConfigEnv.UPDATE_FIREWALL] and Line 195: managers it is ok to ignore value if not required, we are not doing human validations on answer files. it is ok not to accept none per above question. Line 196: ): Line 197: self.dialog.note( Line 198: text=_( Line 199: 'The following firewall managers were detected on ' -- To view, visit http://gerrit.ovirt.org/20737 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3c1a634b2e8539ebd604205b5487290c8d8a1a9 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
