Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: update firewall for all services ......................................................................
Patch Set 7: (4 comments) the output of manual should be printed only for the right manager, I cannot see it. .................................................... File packaging/setup/plugins/ovirt-engine-setup/config/websocket_proxy.py Line 74: self._enabled = True Line 75: Line 76: self._needStart = self.services.status( Line 77: name='ovirt-websocket-proxy', Line 78: ) ok... I take it back... this start should be done only in non dev mode. Line 79: Line 80: @plugin.event( Line 81: stage=plugin.Stages.STAGE_CUSTOMIZATION, Line 82: name=osetupcons.Stages.CONFIG_WEBSOCKET_PROXY_CUSTOMIZATION, .................................................... File packaging/setup/plugins/ovirt-engine-setup/network/firewall_manager.py Line 168: active_managers.append(manager) Line 169: Line 170: if ( Line 171: self.environment[osetupcons.ConfigEnv.UPDATE_FIREWALL] is None and Line 172: managers active_managers? BTW: why do you need to keep both managers and active_managers? you have the potentials and you have the actual, why do we need something more... I cannot understand this from the code bellow. Line 173: ): Line 174: self.dialog.note( Line 175: text=_( Line 176: 'Setup can automatically configure the firewall ' Line 195: ) Line 196: Line 197: if ( Line 198: self.environment[osetupcons.ConfigEnv.FIREWALL_MANAGER] is None Line 199: and self.environment[osetupcons.ConfigEnv.UPDATE_FIREWALL] move and up... and why not add the len(managers) into above condition? Line 200: ): Line 201: if len(managers) > 1: Line 202: self.dialog.note( Line 203: text=_( Line 259: ) Line 260: self.environment[otopicons.NetEnv.FIREWALLD_ENABLE] = ( Line 261: self.environment[ Line 262: osetupcons.ConfigEnv.FIREWALL_MANAGER Line 263: ] == 'firewalld' constants for these? Line 264: ) Line 265: Line 266: @plugin.event( Line 267: stage=plugin.Stages.STAGE_VALIDATION, -- To view, visit http://gerrit.ovirt.org/20737 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3c1a634b2e8539ebd604205b5487290c8d8a1a9 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
