Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: update firewall for all services
......................................................................
Patch Set 6:
(4 comments)
....................................................
File packaging/setup/ovirt_engine_setup/constants.py
Line 937: @osetupattrs(
Line 938: answerfile=True,
Line 939: summary=True,
Line 940: description=_('Update Firewall'),
Line 941: postinstallfile=False, # Force users to ack firewall changes
this is the default, you can just remove it
Line 942: )
Line 943: def UPDATE_FIREWALL(self):
Line 944: return 'OVESETUP_CONFIG/updateFirewall'
Line 945:
....................................................
File packaging/setup/plugins/ovirt-engine-setup/config/websocket_proxy.py
Line 71
Line 72
Line 73
Line 74
Line 75
so you can drop the above condition for developer mode as well.
if there is store then we have it configured.
....................................................
File packaging/setup/plugins/ovirt-engine-setup/network/firewall_manager.py
Line 145: )
Line 146: def _customization(self):
Line 147: self._supported_managers = self.environment[
Line 148: osetupcons.ConfigEnv.SUPPORTED_FIREWALL_MANAGERS
Line 149: ].split(',')
please also trim
Line 150:
Line 151: managers = []
Line 152: for manager in self._supported_managers:
Line 153: if self.services.exists(manager):
Line 191:
Line 192: if (
Line 193: self.environment[osetupcons.ConfigEnv.FIREWALL_MANAGER]
is None and
Line 194: self.environment[osetupcons.ConfigEnv.UPDATE_FIREWALL] and
Line 195: managers
and len(manager) > 1 ? I mean auto select if there is only one.
Line 196: ):
Line 197: self.dialog.note(
Line 198: text=_(
Line 199: 'The following firewall managers were detected on
'
--
To view, visit http://gerrit.ovirt.org/20737
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3c1a634b2e8539ebd604205b5487290c8d8a1a9
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
